[BUG] Clear all button

[BUG] Clear all button

RaidekRaidek Posts: 69Questions: 7Answers: 0

Link to test case:
http://live.datatables.net/varekana/1/edit

Description of problem:
There is a scenario in which the search pattern reported in the record search fields can only be deleted manually, since the "x" filter delete button is disabled when the "Clear All" button is clicked. This occurs by hand reporting a search field, with a search pattern with matches in that field, and one of those matches is selected. If the "Clear All" button is then pressed, the field remove filter "x" is disabled, but the entered search pattern is still reported in the field and the only way to remove it is by hand.

Reproduction of the defect (example)

  1. Write to the filter <input> of "Position" a search pattern that matches the filter, for example, "Sy"

  2. One of the matches shown in the list in the filter field is selected

  3. The "Clear All" button is pressed

  4. It is observed that the delete filter button "x" has been disabled, and that the entered search pattern "Sy" is still reported in the field.

Video: https://youtu.be/mDXbI-sVQyQ

Replies

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    Thank you - agreed, that's a bug. I'll get it fixed for the next release.

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Thanks @allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @allan , Do you know when the new version will come out?

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    I'd hoped it would be tomorrow or Friday. I'm now not sure that will be the case though. If it isn't, then it will drop next week.

    Allan

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    I'm not sure exactly when I fixed this, but it appears to be working with the nightly version of SearchPanes here: http://live.datatables.net/dokujuki/1/edit .

    If you could confirm that is working for you, it would be really useful.

    Thanks,
    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @allan , I have seen that you have stable updated Datatable to 1.13.2, SearchPanes to 2.1.1 and Select to 1.6.0.

    But the problem has not been fixed, what you see in the video: https://youtu.be/mDXbI-sVQyQ

    The problem is that after clicking "Clear all" the "x" button is disabled and you have to delete by hand what you have written in the input.

    I have also tried your example http://live.datatables.net/dokujuki/1/edit, but I don't see that this problem is solved either.

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    Got it! That you for clarifying this for me. I've committed the fix and it will be in the nightly build shortly.

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Great I'll try it as soon as I can. Thanks @allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0
    edited February 2023

    Hello @allan , first of all let me tell you that http://live.datatables.net has stopped working:

    I'm from Spain when loading your example from before:
    http://live.datatables.net/dokujuki/1/edit
    It returns me this error:

    On the other hand, I have tried the nightly and it fixes the problem, but many others arise.

    Since I don't have access to https://live.datatables.net/ I can't show you what's going on.

    But if you have access to the previous example, put the SearchPanes nightly in it, I'll explain what happens:
    1. Write something in a filter so that fewer options appear.
    2. Select one and you will see that your entry has been deleted and you have to write it again.

    Also, I found another error:
    If you click directly on the filter to write something, it is displayed, but the button to collapse all is not activated.

  • kthorngrenkthorngren Posts: 20,269Questions: 26Answers: 4,765

    The problem is likely that your browser is trying to use SSL and changing the URL from HTTP to HTTPS. Maybe try another browser.

    Kevin

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @kthorngren . I tried with Chrome and Edge and i got the same result.

  • kthorngrenkthorngren Posts: 20,269Questions: 26Answers: 4,765
  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @kthorngren.
    It worked for me on Edge. But I keep insisting that something must happen, because I have tried different networks, computers and mobile devices and the same thing happens. I'm from Spain, I think that has something to do with it.

    Something similar happened to me and I reported it on the forum and it was indeed a problem with my location.

    https://datatables.net/forums/discussion/72845/all-examples-are-broken-on-the-web#latest

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    Yes, I need to make changes at my end to make it accessible. I'm working on that as quickly as possible, while still doing other things such as support.

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Ok @allan
    I'll wait then for you to fix the http://live.datatables.net thing.
    After that I will be able to send you a video with what happens with the SearchPanes nightly and the new bug that I have found. I also explain both things in the previous message.

    On the other hand, I have tried the nightly and it fixes the problem, but many others arise.

    Since I don't have access to https://live.datatables.net/ I can't show you what's going on.

    But if you have access to the previous example, put the SearchPanes nightly in it, I'll explain what happens:
    1. Write something in a filter so that fewer options appear.
    2. Select one and you will see that your entry has been deleted and you have to write it again.

    Also, I found another error:
    If you click directly on the filter to write something, it is displayed, but the button to collapse all is not activated.

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @allan
    Here is this example:
    https://live.datatables.net/dokujuki/2/edit?html,js,output

    First bug: https://youtu.be/oT1Hx7fJ62k
    But if you have access to the previous example, put the SearchPanes nightly in it, I'll explain what happens:
    1. Write something in a filter so that fewer options appear.
    2. Select one and you will see that your entry has been deleted and you have to write it again.

    Second bug: https://youtu.be/17F6b_h3S_I
    If you click directly on the filter input to type something, the filter is displayed, but the button to collapse all is not activated.

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hello @allan, as always meme I wait 10 days to post again.

    Are there any updates on the bugs that I mentioned in the previous message?

    Thank you so much.

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    Hi - apologies for the delay in replying here. I agree - both points are bugs that I will address. Hopefully I'll be able to dig into it this week.

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Did they throw it in a nightly?

    If so, could you let me know?

    Thank you so much @allan

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    I've fixed the second issue with the show all / collapse all buttons classes.

    The first issue with the search text being removed - I'll need to get back to that one. I've got a bad feeling about that one...

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Hi @allan,

    Something new?

    Thanks :smiley:

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    No -0 I'll update this thread when I have anything to report back about the first issue, but I think that one might not be addressable for a while.

    Allan

  • RaidekRaidek Posts: 69Questions: 7Answers: 0

    Any advance? @allan

  • allanallan Posts: 61,650Questions: 1Answers: 10,094 Site admin

    Not yet. I'm planning a major overhaul of SearchPanes, but I haven't been able to prioritise that over other work yet (I'm a one person dev, support, admin, etc team for the whole project!). As I mentioned, that outstanding issue will likely be a while before it is addressed.

    Allan

Sign In or Register to comment.